chore: replace avast/retry-go with k8s wait utility#2968
chore: replace avast/retry-go with k8s wait utility#2968mikelolasagasti wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
This commit removes the `avast/retry-go` dependency by migrating the `CacheSyncingClient` to the standard k8s `wait.PollUntilContextTimeout` utility. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikelolasagasti The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @mikelolasagasti! |
|
Hi @mikelolasagasti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
This PR removes the external
github.com/avast/retry-godependency by migrating theCacheSyncingClienttest utility to the standard Kubernetesk8s.io/apimachinery/pkg/util/waitpackage.How was this change tested?
Verified by running the existing test suite that utilizes the
CacheSyncingClient. The tests continue to pass with the new polling logic.