Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: baoalvin1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @baoalvin1! |
|
Hi @baoalvin1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@baoalvin1: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I think the test failure is unrelated, my change doesn't touch |
Fixes #2969
Description
Upgrades KWOK to v0.6.0, latest KWOK 0.7.0 gave errors when upgrading directly so will make a follow up pr
How was this change tested?
Tested locally by running the
make install-kwokcommand and everything seems to workBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.