feat: add support for 'kustomize edit add configuration' command by rohithnarasimha · Pull Request #6037 · kubernetes-sigs/kustomize

rohithnarasimha · 2025-12-17T12:31:18Z

Add a new subcommand 'kustomize edit add configuration' to programmatically add configuration file references to kustomization.yaml files. This brings configurations support in line with other 'kustomize edit add' subcommands (generators, transformers, validators).
Features:

Support for single and multiple configuration file paths
Glob pattern expansion (e.g., ./configs/*.yaml)
Duplicate detection with user logging
Idempotent operation

Fixes #5987

linux-foundation-easycla · 2025-12-17T12:31:26Z

The committers listed above are authorized under a signed CLA.

✅ login: rohithnarasimha / name: Rohith (1af74f2)

k8s-ci-robot · 2025-12-17T12:31:26Z

Welcome @rohithnarasimha!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-12-17T12:31:27Z

Hi @rohithnarasimha. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rohithnarasimha · 2025-12-20T05:41:46Z

/ok-to-test

k8s-ci-robot · 2025-12-20T05:42:02Z

@rohithnarasimha: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rohithnarasimha · 2025-12-20T05:43:39Z

@koba1t @varshaprasad96
can you please review and please proved sign to test

koba1t · 2026-03-12T13:29:52Z

/ok-to-test

rohithnarasimha · 2026-03-12T15:18:05Z

@koba1t Prow shows all tests have passed (https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes-sigs%2Fkustomize+author%3Arohithnarasimha), but the GitHub "Lint" and "Test Summary" checks are stuck in "Waiting for status to be reported".

This appears to be a status reporting issue since the actual Prow jobs completed successfully.

Could you please review the code and proceed with /lgtm and /approve if everything looks good?

varshaprasad96 · 2026-04-01T00:32:53Z

/retest

varshaprasad96

This looks good. Can follow up by adding more tests like: TestAddTransformerNoArgs (to verify no args gives error), verify when customization.yaml is not present, use of wildcard (*).

@koba1t any objections in merging this?

varshaprasad96 · 2026-04-01T00:41:55Z

kustomize/commands/edit/add/addconfiguration_test.go

+	// Count occurrences - should only appear once
+	count := 0
+	data := string(content)
+	for i := 0; i < len(data); {


Nit (not a blocker) - The manual substring search loop is fragile and hard to read. The transformer test uses a much cleaner approach — read back via kustfile.NewKustomizationFile, parse, and assert len(m.Configurations) == 1. We could also use strings.Count(data, "config.yaml").

k8s-ci-robot · 2026-04-01T00:43:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohithnarasimha, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

varshaprasad96 · 2026-04-01T19:02:23Z

This PR cannot be merged, till required tests pass. Closing and reopening to see if it re-triggers.

varshaprasad96 · 2026-04-01T19:18:43Z

@rohithnarasimha can you fix the linters pls?

rohithnarasimha · 2026-04-02T04:14:57Z

sure

…ation' command Add a new subcommand 'kustomize edit add configuration' to programmatically add configuration file references to kustomization.yaml files. This brings configurations support in line with other 'kustomize edit add' subcommands (generators, transformers, validators). Features: - Support for single and multiple configuration file paths - Glob pattern expansion (e.g., ./configs/*.yaml) - Duplicate detection with user logging - Idempotent operation Related to kubernetes-sigs#5987

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 17, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 17, 2025

k8s-ci-robot requested review from koba1t and varshaprasad96 December 17, 2025 12:31

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2025

rohithnarasimha force-pushed the feat/add-configuration-command branch 2 times, most recently from 0ed0c95 to 5ea06b9 Compare December 20, 2025 05:09

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 20, 2025

rohithnarasimha force-pushed the feat/add-configuration-command branch 4 times, most recently from 3ac1ae2 to 218468e Compare December 20, 2025 05:39

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026

varshaprasad96 approved these changes Apr 1, 2026

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026

varshaprasad96 closed this Apr 1, 2026

varshaprasad96 reopened this Apr 1, 2026

rohithnarasimha force-pushed the feat/add-configuration-command branch from 218468e to 1af74f2 Compare April 6, 2026 01:42

rohithnarasimha requested a review from varshaprasad96 April 7, 2026 04:12

Conversation

rohithnarasimha commented Dec 17, 2025

Uh oh!

linux-foundation-easycla bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Dec 17, 2025

Uh oh!

k8s-ci-robot commented Dec 17, 2025

Uh oh!

rohithnarasimha commented Dec 20, 2025

Uh oh!

k8s-ci-robot commented Dec 20, 2025

Uh oh!

rohithnarasimha commented Dec 20, 2025

Uh oh!

koba1t commented Mar 12, 2026

Uh oh!

rohithnarasimha commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varshaprasad96 commented Apr 1, 2026

Uh oh!

varshaprasad96 left a comment

Choose a reason for hiding this comment

Uh oh!

varshaprasad96 Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 1, 2026

Uh oh!

varshaprasad96 commented Apr 1, 2026

Uh oh!

varshaprasad96 commented Apr 1, 2026

Uh oh!

rohithnarasimha commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linux-foundation-easycla bot commented Dec 17, 2025 •

edited

Loading

rohithnarasimha commented Mar 12, 2026 •

edited

Loading