Add in-place infeasible cached metric#9819
Conversation
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2d91f07 to
a64f2e4
Compare
|
/retest |
| inPlaceInfeasibleCachedCount = prometheus.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Namespace: metricsNamespace, | ||
| Name: "inplace_cache_pods_total", |
There was a problem hiding this comment.
is inplace_cache_pods_total descriptive enough?
There are only ever pods that could be infeasible, I wonder if it makes sense to make it something like:
inplace_infeasible_skip_pods_total ?
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
a64f2e4 to
43d459e
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a Prometheus counter metric (
inplace_cache_pods_total) to track pods that were skipped from in-place updates because the infeasible result was already cached. This provides observability into how often the cache prevents redundant in-place update attempts.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: