Skip to content

Add in-place infeasible cached metric#9819

Open
omerap12 wants to merge 1 commit into
kubernetes:masterfrom
omerap12:InPlaceInfeasibleCached-metric
Open

Add in-place infeasible cached metric#9819
omerap12 wants to merge 1 commit into
kubernetes:masterfrom
omerap12:InPlaceInfeasibleCached-metric

Conversation

@omerap12

@omerap12 omerap12 commented Jun 15, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a Prometheus counter metric (inplace_cache_pods_total) to track pods that were skipped from in-place updates because the infeasible result was already cached. This provides observability into how often the cache prevents redundant in-place update attempts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds a Prometheus counter metric (inplace_cache_pods_total) to track pods that were skipped from in-place updates because the infeasible result was already cached.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. label Jun 15, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler Issues or PRs related to the Vertical Pod Autoscaler component size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Jun 15, 2026
@omerap12

Copy link
Copy Markdown
Member Author

/retest

@omerap12 omerap12 force-pushed the InPlaceInfeasibleCached-metric branch from 2d91f07 to a64f2e4 Compare June 15, 2026 14:05
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 15, 2026
@omerap12

Copy link
Copy Markdown
Member Author

/retest

inPlaceInfeasibleCachedCount = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: metricsNamespace,
Name: "inplace_cache_pods_total",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is inplace_cache_pods_total descriptive enough?
There are only ever pods that could be infeasible, I wonder if it makes sense to make it something like:
inplace_infeasible_skip_pods_total ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12 omerap12 force-pushed the InPlaceInfeasibleCached-metric branch from a64f2e4 to 43d459e Compare June 18, 2026 07:29
@omerap12 omerap12 requested a review from adrianmoisey June 18, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler Issues or PRs related to the Vertical Pod Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants