VPA: Add recommender Prometheus metrics tests#9825
Conversation
|
This issue is currently awaiting triage. If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @mattsu2020! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mattsu2020 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @mattsu2020. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/remove-kind feature |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds unit coverage for the VPA recommender Prometheus RoundTripper metrics introduced for Prometheus history provider API requests.
The new test exercises the counter and duration wrappers with an HTTP response and verifies the expected code and method labels are recorded.
Fixes #8128
Which issue(s) this PR fixes:
Fixes #8128
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Validation: