Apply Provisioned condition with SSA#9842
Open
norbertcyran wants to merge 1 commit into
Open
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/cluster-autoscaler
We noticed a very frequent conflict when adding a Provisioned condition to the ProvisioningRequest. That usually happens in best-effort-atomic PRs, where CA adds Accepted and then Provisioned conditions in a very quick succession. The informer cache does not catch up with the first update, and therefore a conflict is detected during the second update. SSA fixes that, as it allows to update a single condition without a risk of conflict. This solution is preferred over a retry loop, since the API calls run synchronously in the CA main loop. Strategic merge patch could not be used, since it's not supported with CRDs. JSON merge patch replaces the entire conditions list. That leaves SSA an only viable solution. Note: that fixes only the most frequently detected race condition. Eventually, all PR condition updates should be migrated to SSA.
norbertcyran
force-pushed
the
pr-patch-conditions
branch
from
9ce7389 to
d453489
Compare
Contributor
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
jackfrancis
approved these changes
Jun 19, 2026
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, norbertcyran The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
@norbertcyran: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We noticed a very frequent conflict when adding a Provisioned condition to the ProvisioningRequest. That usually happens in best-effort-atomic PRs, where CA adds Accepted and then Provisioned conditions in a very quick succession. The informer cache does not catch up with the first update, and therefore a conflict is detected during the second update. SSA fixes that, as it allows to update a single condition without a risk of conflict. This solution is preferred over a retry loop, since the API calls run synchronously in the CA main loop. Strategic merge patch could not be used, since it's not supported with CRDs. JSON merge patch replaces the entire conditions list. That leaves SSA an only viable solution. Note: that fixes only the most frequently detected race condition. Eventually, all PR condition updates should be migrated to SSA.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: