Allow setting gp3 for terraform volumes without setting throughput

[hakman]

Until hashicorp/terraform-provider-aws#16517 is merged, TF will not be able to use the throughput arg for aws_ebs_volume.

[hakman]

/cc @rifelpet @olemarkus

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rifelpet]

why are we only setting it to nil with this condition? if the throughput field isn't yet supported at all in terraform then I'd think we should always set it to nil?

[rifelpet]

also we should have an integration test that generates this terraform output so that the verify-terraform job will catch it.

[hakman]

It is set to nil if you don't use gp3 volumes. We have integration test in master #10569, but not sure how we can "catch" it.

[rifelpet]

looking at the api docs

    // The throughput to provision for a volume, with a maximum of 1,000 MiB/s.
    //
    // This parameter is valid only for gp3 volumes.
    //
    // Valid Range: Minimum value of 125. Maximum value of 1000.
    Throughput *int64 `type:"integer"`

I feel like we should fail api validation if throughput is < 125 rather than ignoring the value. We could also fail validation if RootVolumeThroughput is set for RootVolumeTypes other than gp3 (and if cloudprovider != aws )

This is the only throughput validation we have currently:

kops/pkg/apis/kops/validation/instancegroup.go

Lines 72 to 74 in 0410058

	if fi.Int32Value(g.Spec.RootVolumeThroughput) < 0 {
	allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "rootVolumeThroughput"), g.Spec.RootVolumeThroughput, "RootVolumeThroughput must be greater than 0"))
	}

[hakman]

We could, but it's not really this hack's purpose. I just want to not put the value in the TF template if the value is the minimum to not need a new kOps release when TF decides to merge the throughput arg. We set values lower than the minimum to minimum in model.

[rifelpet]

/lgtm