Use kubeconfig flag instead of kubeconfig-dir in kubeadm init phase bootstrap-token#71803
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Dec 6, 2018
Merged
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
Member
Author
|
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews |
neolit123
approved these changes
Dec 6, 2018
Member
neolit123
left a comment
neolit123
left a comment
There was a problem hiding this comment.
thanks for the quick fix @yagonobre
/lgtm
/approve
/priority critical-urgent
/assign @fabriziopandini
should we cherry pick?
k8s-ci-robot
added
priority/critical-urgent
Member
Author
|
+1 from me to cherry pick |
Member
Author
|
/test pull-kubernetes-e2e-kops-aws |
Member
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
timothysc
approved these changes
Dec 6, 2018
Contributor
timothysc
left a comment
timothysc
left a comment
There was a problem hiding this comment.
/hold cancel
/lgtm
/approve
Please cherry-pick and assign to me.
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, timothysc, yagonobre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test pull-kubernetes-e2e-kops-aws |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 10, 2018
…803-upstream-release-1.13 Automated cherry pick of #71803: Use kubeconfig flag instead of kubeconfig-dir in kubeadm init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes kubernetes/kubeadm#1306
Special notes for your reviewer:
bootstrap-token is the unique phase that use
data.Client()andkubeconfig-dirflag, that make sense only in thekubeconfigphaseDoes this PR introduce a user-facing change?:
-->