Change docker metrics to conform metrics guidelines

[danielqsj]

What type of PR is this?

/sig instrumentation

What this PR does / why we need it:

1. As part of kubernetes metrics overhaul, change docker metrics to conform Kubernetes metrics instrumentation guidelines.

2. Change docker metrics to histogram for better aggregation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This patch does not remove the existing metrics but mark them as deprecated.
We need 2 releases for users to convert monitoring configuration.

Does this PR introduce a user-facing change?:

Change docker metrics to conform metrics guidelines and using histogram for better aggregation.
The following metrics are deprecated, and will be removed in a future release:
* `docker_operations`
* `docker_operations_latency_microseconds`
* `docker_operations_errors`
* `docker_operations_timeout`
* `network_plugin_operations_latency_microseconds`
Please convert to the following metrics:
* `docker_operations_total`
* `docker_operations_latency_seconds`
* `docker_operations_errors_total`
* `docker_operations_timeout_total`
* `network_plugin_operations_latency_seconds`

[danielqsj]

/kind feature
/assign @brancz

[liggitt]

What is the compatibility guarantee on metric names/values? Changing metrics this way with no advance notice is likely to cause problems with monitoring over upgrade boundaries. I'm not sure if this falls under an aspect of our deprecation policy that would require a longer pre-announce period, but if not, I'd advocate at least one release overlap where both old and new metrics are available.

[liggitt]

These questions would be good to answer broadly and include in
https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md to inform the other metrics updating efforts

[danielqsj]

@liggitt
Thanks, totally agree.
I already added the previous metrics back and marked them as deprecated.

[danielqsj]

Added Deprecated in metrics description. PTAL

[danielqsj]

/retest

[brancz]

@danielqsj could you open a PR against the metrics overhaul that says that the 1.14 release will have backward compatibility but 1.15 will drop the deprecated metrics and label? Thanks!

[brancz]

/retest

[brancz]

/lgtm

[brancz]

/retest

[brancz]

/retest

[danielqsj]

/retest

[brancz]

/assign @derekwaynecarr

[danielqsj]

@derekwaynecarr can you help review this? Thanks

[danielqsj]

@Random-Liu @sttts @deads2k if you have time, can you help review this? Thanks

[danielqsj]

@derekwaynecarr @Random-Liu @sttts @deads2k ping

[danielqsj]

@thockin @derekwaynecarr @Random-Liu @sttts @deads2k if you have time, can you help review this? Thanks

[sttts]

/assign @derekwaynecarr

for approval.

[derekwaynecarr]

/approve

[brancz]

cc @deads2k @smarterclayton for test/OWNERS approval

[smarterclayton]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, derekwaynecarr, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [derekwaynecarr,smarterclayton]
• test/OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment