Skip to content

remove deprecated openapi paths in favor of /openapi/v2#73148

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:remove-deprecated-swagger-paths
Jan 24, 2019
Merged

remove deprecated openapi paths in favor of /openapi/v2#73148
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:remove-deprecated-swagger-paths

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Jan 21, 2019

What type of PR is this?
/kind cleanup

Which issue(s) this PR fixes:
Fixes #73083

Does this PR introduce a user-facing change?:

The /swagger.json and /swagger-2.0.0.pb-v1 schema documents, deprecated since v1.10, have been removed in favor of `/openapi/v2`

/sig api-machinery
/cc @mbohlool @apelisse

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2019
apelisse
apelisse reviewed Jan 22, 2019
View reviewed changes
hack/update-openapi-spec.sh
kube::log::status "Updating " ${OPENAPI_ROOT_DIR}

curl -w "\n" -fs "${API_HOST}:${API_PORT}/swagger.json" > "${OPENAPI_ROOT_DIR}/swagger.json"
curl -w "\n" -fs "${API_HOST}:${API_PORT}/openapi/v2" > "${OPENAPI_ROOT_DIR}/swagger.json"
Copy link
Copy Markdown
Member

@apelisse apelisse Jan 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that the default is supposed to be JSon, but should we specifically ask for the json version when we want json?

Copy link
Copy Markdown
Member Author

@liggitt liggitt Jan 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily opposed, but having this test the implicit json response doesn't seem bad either

@mbohlool
Copy link
Copy Markdown
Contributor

mbohlool commented Jan 23, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mbohlool

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jan 24, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 31311a6 into kubernetes:master Jan 24, 2019
@liggitt liggitt deleted the remove-deprecated-swagger-paths branch January 24, 2019 16:11
@roycaihw roycaihw mentioned this pull request Jan 29, 2019
Merged
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Adapt default Gardener audit policy
a7e7883 
See kubernetes/kubernetes#73148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apelisse apelisse apelisse left review comments

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@mbohlool mbohlool

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove /swagger.json and other deprecated openapi endpoints

5 participants

@liggitt @mbohlool @k8s-ci-robot @fejta-bot @apelisse
⚡