Skip to content

Remove cluster-monitoring addon tests#15354

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
serathius:remove-cluster-montoring
Jan 10, 2020
Merged

Remove cluster-monitoring addon tests#15354
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
serathius:remove-cluster-montoring

Conversation

@serathius
Copy link
Copy Markdown
Contributor

@serathius serathius commented Nov 21, 2019

Prometheus addon was already removed.
Cluster Monitoring removal PR kubernetes/kubernetes#85512
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2020
@serathius serathius force-pushed the remove-cluster-montoring branch from e375c21 to c026778 Compare January 9, 2020 09:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2020
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Jan 10, 2020

/assign @brancz

@brancz
Copy link
Copy Markdown
Member

brancz commented Jan 10, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@brancz
Copy link
Copy Markdown
Member

brancz commented Jan 10, 2020

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@serathius
Copy link
Copy Markdown
Contributor Author

serathius commented Jan 10, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 63b55af into kubernetes:master Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2020

@serathius: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-instrumentation-config.yaml using file config/jobs/kubernetes/sig-instrumentation/sig-instrumentation-config.yaml
Details

In response to this:

Prometheus addon was already removed.
Cluster Monitoring removal PR kubernetes/kubernetes#85512
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Jun 17, 2021
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chases2 chases2 chases2 left review comments

@fejta fejta Awaiting requested review from fejta

Assignees

@brancz brancz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

4 participants

@serathius @brancz @k8s-ci-robot @chases2
⚡