TSC resolves symlinks but ts-jest does not

[KSXGitHub]

Issue

TypeScript command resolves symlinked modules but ts-jest does not.

Steps to reproduce

I have a node_modules structure looks like this (generated by using pnpm as package manager):

+ index.ts
+ node_modules/
    + bar (symlink) → .registry.npmjs.org/1.2.3/node_modules/bar
    + .registry.npmjs.org/1.2.3/node_modules/
      + foo/index.ts
      + bar/index.ts

<root>/index.ts:

import Bar from 'bar'

export default class Root extends Bar {
  getData () {
    return this.data // 'protected data' from 'class Foo' of package 'foo'
  }
}

<root>/node_modules/.registry.npmjs.org/1.2.3/node_modules/foo/index.ts:

import Foo from 'foo'
export default class Bar extends Foo {}

<root>/node_modules/.registry.npmjs.org/1.2.3/node_modules/bar/index.ts:

export default class Foo {
  protected data = 123
}

Expected behavior

No errors

Current behavior

error TS2339: Property 'data' does not exist

---

This is travis log in my project: https://travis-ci.org/ksxnodemodules/external-dependencies/builds/444756379

[huafu]

@KSXGitHub I believe this is not related to symlinks. What is your tsconfig and jest config?

[KSXGitHub]

@huafu

What is your tsconfig and jest config?

tsconfig.json

jest.config.js

NOTES:

• The two files are not in the same directory.
• Jest, ts-jest and typescript is installed in a subdirectory (<root>/tools/jest).
• I use commands from the subdirectories to compile/test the whole monorepo.

I believe this is not related to symlinks

It was fine with flat node_modules (direct and indirect dependencies are in the same level). But when I switch most of my packages to pnpm's strict nested node_modules, ts-jest yields errors while TSC does not. The only explanation I could think of is that TSC resolves symlinks before compiling them while ts-jest does not.

[huafu]

Looking at your repo, those are weird linkage going on lol

Anyway, where is the advanced-set-mutable-multi-key package? Sounds like this is the one containing the MultiKeySet which must declare data property since it is not declared in the RelationshipSet type.

[huafu]

@KSXGitHub if you are sure it's related to symlinks, then I think this issue needs to be moved to jest. As a jest transformer, we are given a file path and then using it to read the file's content using system reads such as fs.readFileSync.

THe only thing I see that could come in to mess up everything is the cache, so you should try to see if you still have the issue when you run the tests with --no-cache.

[KSXGitHub]

As a jest transformer, we are given a file path and then using it to read the file's content using system reads such as fs.readFileSync.

Can you just fs.realpath() on that file path?

THe only thing I see that could come in to mess up everything is the cache, so you should try to see if you still have the issue when you run the tests with --no-cache.

This fails even in CI.

[huafu]

Can you just fs.realpath() on that file path?

this won't change anything, and I forgot to mention that we actually do not read the file as jest gives us its content as well

As asked there #825 (comment) where can I find the source of advanced-set-mutable-multi-key package, I need to see the signature of MultiKeySet

[KSXGitHub]

As asked there #825 (comment) where can I find the source of advanced-set-mutable-multi-key package, I need to see the signature of MultiKeySet

advanced-set-mutable-multi-key/index.ts

advanced-set-base/index.ts

[huafu]

I'll need to have some more time to clone your repo and check locally... but I'm pretty sure it's not related to ts-jest

[KSXGitHub]

You may need to use pnpm (in place of yarn/npm) as well to produce the same layout.
Read .travis.yml for further instruction.

[cortopy]

I think this can be closed. Works for me probably because of pnpm/pnpm#1007

[KSXGitHub]

I think this can be closed. Works for me probably because of pnpm/pnpm#1007

The test works just fine, but it prints warning, corrupting terminal output, which is what this issue is about

[GeeWee]

Please provide a minimal reproducible repository. There seems to be a whole slew of issues in relation to pnpm.

[dashmug]

This happens when running jest (with ts-jest) inside AWS CodeBuild when using CodeBuild's caching feature.

The way CodeBuild's caching work is that they cache node_modules between builds. At the beginning of a build, CodeBuild symlinks the cache directory in your project's node_modules. I think this is similar to pnpm's symlinking feature.

Also, this does not happen on my local machine using yarn.