fix(docs): adjust changelog, correct version in package.json#1406
Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom Feb 21, 2020
ahnpnl:fix-readme-release
Merged
fix(docs): adjust changelog, correct version in package.json#1406ahnpnl merged 1 commit intokulshekhar:masterfrom ahnpnl:fix-readme-release
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:fix-readme-release
Conversation
Owner
|
@ahnpnl thanks! yeah, I forgot to push the published version back to Github this time 🤦♂️ |
kulshekhar
approved these changes
Feb 21, 2020
Pull Request Test Coverage Report for Build 4057
💛 - Coveralls |
Collaborator
Author
|
I also created a 25.2.1 tag for release page 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kulshekhar I saw you forgot to adjust version
package.jsonfor release 25.2.1 so this PR is to adjust it, and also correct changelog for releases of v24 and v25.Our command to generate changelog depends on our commit history so it's a bit messy with v24 and v25 changelog so I had to manually modify it. Just a note to let you know if you generate the changelog by our command.
I think when merging, better we use squash and merge to keep the commit history clean to be easy to generate changelog.