perf(compiler): use moduleResolutionCache for Language Service's resolveModuleNames#1786
Merged
ahnpnl merged 2 commits intokulshekhar:masterfrom Jul 8, 2020
ahnpnl:cache-module-resolution
Merged
perf(compiler): use moduleResolutionCache for Language Service's resolveModuleNames#1786ahnpnl merged 2 commits intokulshekhar:masterfrom ahnpnl:cache-module-resolution
ahnpnl merged 2 commits intokulshekhar:masterfrom
ahnpnl:cache-module-resolution
Conversation
Pull Request Test Coverage Report for Build 5297
💛 - Coveralls |
kulshekhar
approved these changes
Jul 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1784 introduced the usage
resolveModuleNamesAPI fromLanguageService. I noticed thatresolveModuleNamesAPI can have a cache calledModuleResolutionCacheso I went ahead and tried out. The result is amazing:Some figures
Testing against my company's project which has 2k+ test files as well as the repo source has 2k+ files.
After #1784
With this PR
Some tests gain huge performance boost and overall, the time to execute the tests for the whole project improved about 20%-30%.
The difference in time between no cache run and cache run reduces to no-cache run = x1.5-2x cache run comparing to no-cache run = 2x-2.5x cache run after #1784
Test plan
Added unit test for checking the usage of
ts.createModuleResolutionCache. Green CIDoes this PR introduce a breaking change?
Other information
I also correct test for
config-set.tswhich reduced coverage in #1784