Skip to content

fix: move @types/jest to dependencies to work well with yarn 2#1859

Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:types-jest-dep
Aug 6, 2020
Merged

fix: move @types/jest to dependencies to work well with yarn 2#1859
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:types-jest-dep

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented Aug 5, 2020

Summary

Because we export mocked, a util function, as a public function but we also refer to @types/jest here which isn’t complied with yarn 2

This PR moves @types/jest to dependencies list.

Fixes #1857

Test plan

Pack a tgz file and install with yarn 2 to the project in #1857

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner August 5, 2020 19:30
@ahnpnl ahnpnl closed this Aug 5, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 5, 2020

Pull Request Test Coverage Report for Build 5577

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.989%

Totals Coverage Status
Change from base Build 5576: 0.0%
Covered Lines: 1093
Relevant Lines: 1128

💛 - Coveralls

@ahnpnl ahnpnl reopened this Aug 5, 2020
kulshekhar
kulshekhar previously approved these changes Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yarn 2 and Plug'n'Play

3 participants