feat: allow ast transformers to take in addl opts, fix #1942

[longlho]

Summary

See #1942

Test plan

Changed existing unit test

Does this PR introduce a breaking change?

• No

Other information

[longlho]

cc @ahnpnl

[ahnpnl]

nice ! So actually just simply pass the option to factory.

[ahnpnl]

the codes LGTM, only missing unit tests and e2e tests

[longlho]

@ahnpnl I'm not sure how to add e2e test since the doc is broken. Also idk why existing test failed :-/ Can u provide some help?

[ahnpnl]

You can follow these steps:

• Add a new file to https://github.com/kulshekhar/ts-jest/tree/master/e2e/__tests__ , maybe with the name transformer-with-option.test.ts.

• Add a new folder to https://github.com/kulshekhar/ts-jest/tree/master/e2e/__cases__ maybe folder name is transformer-with-option. This folder will have 2 files, one is transformer-with-option.ts, another one is transformer-with-option.spec.ts.

• In transformer-with-option.ts, you can make a dummy transformer which will use the option from config, maybe just console.log the option to prove that the option is passed correctly from config ?

• In transformer-with-option.spec.ts, there will be the main test, which to prove that when you run it, it should provide the expected result. For example, if the dummy transformer prints out the option, the test here should expect that the log is printed out.

• In the folder https://github.com/kulshekhar/ts-jest/tree/master/e2e/__tests__ , the file transformer-with-option.test.ts, you can copy the example from https://github.com/kulshekhar/ts-jest/blob/master/e2e/__tests__/ts-jest-utils.test.ts . The function configureTestCase accepts a string, which matches with the folder's name created in https://github.com/kulshekhar/ts-jest/tree/master/e2e/__cases__

• To run e2e, first you need to run test:prepare. This will install dependencies and create a folder for symlink. After that, you can go to any files in https://github.com/kulshekhar/ts-jest/tree/master/e2e/__tests__ to run any tests you want.

[ahnpnl]

Do you get somewhere with e2e tests ? I can also take over if you don’t mind :)

[longlho]

That’d be amazing thanks!

…

On Thu, Sep 17, 2020 at 8:16 AM Ahn ***@***.***> wrote: Do you get somewhere with e2e tests ? I can also take over if you don’t mind :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1946 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQM34F4QPC2WBPA3JM2ELSGH4ZVANCNFSM4RJXESUA> .

[ahnpnl]

Continue in #1966