refactor(config): expose only create config set and compiler apis#2355
Merged
ahnpnl merged 1 commit intokulshekhar:masterfrom Feb 13, 2021
ahnpnl:simplify-extend-transformer-apis
Merged
refactor(config): expose only create config set and compiler apis#2355ahnpnl merged 1 commit intokulshekhar:masterfrom ahnpnl:simplify-extend-transformer-apis
ahnpnl merged 1 commit intokulshekhar:masterfrom
ahnpnl:simplify-extend-transformer-apis
Conversation
Pull Request Test Coverage Report for Build 564415020
💛 - Coveralls |
kulshekhar
previously approved these changes
Feb 13, 2021
kulshekhar
approved these changes
Feb 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
_createConfigSetand_createCompilermethods so subclasses can just use those if they need to create their own instances.Test plan
Added unit tests, green CI
Does this PR introduce a breaking change?
Other information
N.A.