Skip to content

fix: don't show warning message with Node16/NodeNext#4377

Merged
ahnpnl merged 1 commit intomainfrom
fix/esmodule-interdop
Jun 17, 2024
Merged

fix: don't show warning message with Node16/NodeNext#4377
ahnpnl merged 1 commit intomainfrom
fix/esmodule-interdop

Conversation

@ahnpnl
Copy link
Copy Markdown
Collaborator

@ahnpnl ahnpnl commented Jun 16, 2024

Summary

fixes #4266

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner June 16, 2024 21:25
@ahnpnl ahnpnl force-pushed the fix/esmodule-interdop branch from 8221886 to 000b304 Compare June 16, 2024 21:26
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2024

Pull Request Test Coverage Report for Build 9539012309

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix/esmodule-interdop at 96.034%

Totals Coverage Status
Change from base Build 9538506470: 96.0%
Covered Lines: 4050
Relevant Lines: 4149

💛 - Coveralls

@ahnpnl ahnpnl merged commit 99c4f49 into main Jun 17, 2024
@ahnpnl ahnpnl deleted the fix/esmodule-interdop branch June 17, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Should Not Show Warning About esModuleInterop If module is node16 or nodenext

3 participants