[beta] Use the proper way of mutating a node in a transformer#703
Merged
kulshekhar merged 2 commits intokulshekhar:betafrom Sep 8, 2018
Merged
[beta] Use the proper way of mutating a node in a transformer#703kulshekhar merged 2 commits intokulshekhar:betafrom
kulshekhar merged 2 commits intokulshekhar:betafrom
Conversation
Mutate a clone of the node instead of mutating directly the original node. Thanks @cspotcode !
kulshekhar
approved these changes
Sep 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't change the generate code, but as @cspotcode pointed me out, this creates a mutable node before actually mutating it.
Ti doesn't change anything in the generated code (of what I've tested and what is in the e2e tests), but cloning readonly stuff before mutating is always advised right 🤣?
There is also a fix for the transformer boilerplate code anyway.