warn instead of forcing ESM interoperability#736
Merged
huafu merged 1 commit intokulshekhar:masterfrom Sep 20, 2018
Merged
Conversation
Pull Request Test Coverage Report for Build 1863
💛 - Coveralls |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow the required override of
modulets config value, theesModuleInteropis set totrue. But that has been done in all the cases.For more flexibility, only
allowSyntheticDefaultExportsis set totruein the case wheremoduleis something else thancommonjsANDesModuleInteropis not set totrue. Also in that case a diagnostic is reported which by default would fail the compilation (but can be bypassed using the diagnostic filtering system).This also means that user can stick to deprecated/not standardised version of
importif they want.This fixes #737