Skip to content

Emit declaration files, filtering out internals#747

Merged
huafu merged 2 commits intokulshekhar:masterfrom
huafu:declaration-file
Sep 21, 2018
Merged

Emit declaration files, filtering out internals#747
huafu merged 2 commits intokulshekhar:masterfrom
huafu:declaration-file

Conversation

@huafu
Copy link
Copy Markdown
Collaborator

@huafu huafu commented Sep 21, 2018

Closes #745

FYI reviewers all changes are about adding the @internal comment and changing the tsconfig so that declaration files are emitted.
Some files look like more changes, but it's just some re-ordering of methods depending on their modifiers which has been done automatically by the linter. Some other changes might be the refactoring from export {...} to individual exports as the @internal does not work within export maps.

@huafu huafu added this to the 23.10.2 milestone Sep 21, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 21, 2018

Pull Request Test Coverage Report for Build 1881

  • 22 of 22 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 90.732%

Totals Coverage Status
Change from base Build 1879: -0.04%
Covered Lines: 966
Relevant Lines: 1015

💛 - Coveralls

@huafu
Copy link
Copy Markdown
Collaborator Author

huafu commented Sep 21, 2018

Weird, why overages decreased since there was no code change? could the extraction of export {...} into single exports do that?

@huafu huafu requested a review from kulshekhar September 21, 2018 13:23
@huafu huafu merged commit a6bcec4 into kulshekhar:master Sep 21, 2018
@huafu huafu deleted the declaration-file branch September 21, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants