Emit declaration files, filtering out internals#747
Merged
huafu merged 2 commits intokulshekhar:masterfrom Sep 21, 2018
Merged
Conversation
Pull Request Test Coverage Report for Build 1881
💛 - Coveralls |
Collaborator
Author
|
Weird, why overages decreased since there was no code change? could the extraction of |
kulshekhar
approved these changes
Sep 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #745
FYI reviewers all changes are about adding the
@internalcomment and changing the tsconfig so that declaration files are emitted.Some files look like more changes, but it's just some re-ordering of methods depending on their modifiers which has been done automatically by the linter. Some other changes might be the refactoring from
export {...}to individual exports as the@internaldoes not work within export maps.