Commit 3435676
authored
Support emissive strength in Standard Surface to glTF PBR (AcademySoftwareFoundation#2593)
closes: AcademySoftwareFoundation#2584
Instead of multiplying the emissive color (factor) and the emission (strength) in the translation graph, we now pass them through to the `gltf_shader`, which do the multiplication, since [KHR_materials_emissive_strength](https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_emissive_strength) is implemented in `gltf_pbr`.
The main difference in the current implementation between standard surface and gltf_pbr for emission is that standard surface takes the coat into consideration ([as emission is below the coat layer](https://autodesk.github.io/standard-surface/#closures/emission)). The gltf spec also layers emission below the coat, however not implemented in `gltf_pbr` currently, more info in issue: AcademySoftwareFoundation#2592. Even if the coat interaction differs a bit, I think we can just pass the emission and emission color through as both the shading models otherwise have the same implementation.1 parent b48cb28 commit 3435676
1 file changed
Lines changed: 8 additions & 4 deletions
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
188 | 189 | | |
189 | 190 | | |
190 | 191 | | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
195 | 198 | | |
196 | 199 | | |
197 | 200 | | |
| |||
212 | 215 | | |
213 | 216 | | |
214 | 217 | | |
| 218 | + | |
215 | 219 | | |
216 | 220 | | |
217 | 221 | | |
0 commit comments