Open
Conversation
Update unit tests.
* Improvements to noise implementations (AcademySoftwareFoundation#1653) - Leverage node graphs to share the conversion aspects of noise implementations across languages. - Simplify noise unit tests to cover only unique implementations. * Fix shader generation typos This changelist fixes a handful of minor typos in shader generation, introduced in AcademySoftwareFoundation#1355 and AcademySoftwareFoundation#1553. * Add frame capture to web viewer (AcademySoftwareFoundation#1636) Add frame capture code to trigger on 'f' key. This is the same key as used for the desktop viewer. * Document format updates This changelist applies the mxformat.py script to the libraries and resources folders in the repository, updating formatting for a handful of documents. --------- Co-authored-by: Jonathan Stone <jstone@lucasfilm.com>
kwokcb
force-pushed
the
main
branch
3 times, most recently
from
1db68be to
a9bb295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graph TB; parentNG_childNG_childNGInput2([childNGInput2]) ==".in2"==> parentNG_childNG_multiplyNode parentNG_childNG_childNGOutput([parentNG/childNG/childNGOutput]) --".in1"--> parentNG_parentmultiplyNode([parentNG/parentmultiplyNode]) parentNG_childNG_multiplyNode([parentNG/childNG/multiplyNode]) --> parentNG_childNG_childNGOutput([childNGOutput]) parentNG_childNG_childNGInput([childNGInput]) ==".in1"==> parentNG_childNG_multiplyNode parentNG_parentmultiplyNode([parentNG/parentmultiplyNode]) --> parentNG_parentNGOutput2([parentNGOutput2]) parentNG_childNG_childNGOutput([childNGOutput]) --> parentNG_parentNGOutput1([parentNGOutput1]) parentNG_parentNGInput1([parentNGInput1]) ==> parentNG_childNG_childNGInput parentNG_parentNGInput2([parentNGInput2]) ==> parentNG_childNG_childNGInput2 parentNG_parentNGInput3([parentNGInput3]) ==".in2"==> parentNG_parentmultiplyNode parentNG_parentNGOutput2([parentNG/parentNGOutput2]) --".base_color"--> nested_graph_shader([nested_graph_shader]) parentNG_parentNGOutput1([parentNG/parentNGOutput1]) --".base_color"--> nested_graph_shader2([nested_graph_shader2]) nested_graph_shader([nested_graph_shader]) --".surfaceshader"--> nested_graph_material([nested_graph_material]) nested_graph_shader2([nested_graph_shader2]) --".surfaceshader"--> nested_graph_material2([nested_graph_material2]) %% Subgraphs subgraph parentNG: parentNG_parentmultiplyNode parentNG_parentNGOutput1 parentNG_parentNGOutput2 parentNG_parentNGInput1 parentNG_parentNGInput2 parentNG_parentNGInput3 subgraph parentNG_childNG: parentNG_childNG_childNGInput parentNG_childNG_multiplyNode parentNG_childNG_childNGOutput parentNG_childNG_childNGInput2 end end %% Style style parentNG_parentNGInput1 fill:#0CF, color:#111 style parentNG_parentNGInput2 fill:#0CF, color:#111 style parentNG_parentNGInput3 fill:#0CF, color:#111 style parentNG_childNG_childNGInput fill:#0CF, color:#111 style parentNG_parentNGOutput2 fill:#0C0, color:#111 style parentNG_parentNGOutput1 fill:#0C0, color:#111 style parentNG_childNG_childNGInput2 fill:#0CF, color:#111 style nested_graph_material2 fill:#0C0, color:#111 style nested_graph_material fill:#0C0, color:#111 style parentNG_childNG_childNGOutput fill:#0C0, color:#111