Conversation
…ardless of where it's used: load, preview, download. Set default to jpg. With "desiredTextureFormat" URI argument to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the PolyHaven MaterialX packaging workflow, focusing on performance, flexibility, and user experience. The most significant changes include switching ZIP compression from JSZip to fflate for faster and more efficient packaging, adding support for configurable texture formats, and enhancing the UI and loading behavior for the materials grid. Additionally, there are updates to documentation and minor code cleanups.
MaterialX Packaging and Compression:
jsPolyHavenLoader.js, resulting in faster package creation and reduced resource usage. All ZIP file creation and file addition logic now use fflate's API and Uint8Array blobs. [1] [2]Texture Format Flexibility:
UI and Loading Experience:
index.html.These changes collectively enhance the performance, flexibility, and usability of the PolyHaven MaterialX workflow.