Mosfet gate anchor is not positioned correctly

[Pyrix25633]

Description

I would expect the gate node to be, well, where the gate is, right?

I would also like it to have the "no-arrow" but "circle" to indicate "p" or "n" as shown here on wikipedia, since it is the representation used on my academic course (not the everything encased thing, that is already implemented)

Reproduction

#circuit({
  pmos("m", (2,0), mode: "depletion", bulk: none, debug: true)
  wire((0,0), "m.g")
})

Zap Version

0.5.0 (default)

Typst Version

0.14.2 (default)

Additional Context

No response

[Pyrix25633]

This is the current result, i think the wire should attach to the perpendicular line

[l0uisgrange]

Hey @Pyrix25633 👋,
Seems indeed to be a mistake. Thanks for reporting it!

[Pyrix25633]

I suggest adding these components/symbols as well, since they are most used in my academic course, code below sorry I really don't have the time to do a pull request and tests etc. :,(

//Not really essential, it was just convenient to me, don't judge, change and optimize at will
#let sum(v, w) = {
  assert(type(v) == array and type(w) == array and v.len() == w.len(), message: "v and w must be arrays of the same lenght")
  let u = ()
  for i in range(v.len()) {
    u += (v.at(i) + w.at(i),)
  }
  u
}

//Does not include the other features, sorry I din't care about them but I really don't have the time
#let mosfet(name,
  node,
  channel: "n",
  floating: false,
  ..params
) = {
  assert(channel in ("n", "p"), message: "channel must be `n` or `p`")
  assert(type(floating) == bool or floating == "electrically-erasable", message: "floating must be of type bool or `electrically-erasable`")

  let draw(ctx, position, style) = {
    let (height, width, base-width, base-spacing, radius) = style
    interface((-height, -width / 2), (0, width / 2))

    let source = (0, -width / 2)
    let drain = (0, width / 2)
    let right = (-height * 3 / 4, width / 2)
    let left = (-height * 3 / 4, -width / 2)
    let gate-right = (-height, width / 2)
    let gate-left = (-height, -width / 2)
    let gate-center = if channel == "n" {
      (-height, 0)
    } else {
      (-height * 5 / 4, 0)
    }
    let gate-top = (-height * 6 / 4, 0)
    if floating != false {
      let offset = (height * 1 / 8, 0)
      right = sum(right, offset)
      left = sum(left, offset)

      let floating-right = (-height * 6.5 / 8, width * 3 / 7)
      let floating-left = (-height * 6.5 / 8, -width * 3 / 7)
      if floating == true {
        wire(floating-right, floating-left)
      }
      else {
        wire(floating-left, sum(floating-right, (0, -width / 7)), (-height * 5.5 / 8, width * 2.5 / 7), floating-right)
      }
    }

    anchor("d", drain)
    anchor("s", source)
    anchor("g", gate-top)

    swire(drain, right, left, source)
    wire(gate-right, gate-left)
    if channel == "p" {
      circle((-height * 4.5 / 4, 0), radius: height * 0.5 / 4, fill: style.fill, name: "c", stroke: 0.5pt)
    }
    wire(gate-center, gate-top)
  }
  component("mosfet", name, node, draw: draw, ..params)
}

[jaehho]

I suggest adding these components/symbols as well, since they are most used in my academic course, code below sorry I really don't have the time to do a pull request and tests etc. :,(

//Not really essential, it was just convenient to me, don't judge, change and optimize at will
#let sum(v, w) = {
assert(type(v) == array and type(w) == array and v.len() == w.len(), message: "v and w must be arrays of the same lenght")
let u = ()
for i in range(v.len()) {
u += (v.at(i) + w.at(i),)
}
u
}

//Does not include the other features, sorry I din't care about them but I really don't have the time
#let mosfet(name,
node,
channel: "n",
floating: false,
..params
) = {
assert(channel in ("n", "p"), message: "channel must be n or p")
assert(type(floating) == bool or floating == "electrically-erasable", message: "floating must be of type bool or electrically-erasable")

let draw(ctx, position, style) = {
let (height, width, base-width, base-spacing, radius) = style
interface((-height, -width / 2), (0, width / 2))

let source = (0, -width / 2)
let drain = (0, width / 2)
let right = (-height * 3 / 4, width / 2)
let left = (-height * 3 / 4, -width / 2)
let gate-right = (-height, width / 2)
let gate-left = (-height, -width / 2)
let gate-center = if channel == "n" {
  (-height, 0)
} else {
  (-height * 5 / 4, 0)
}
let gate-top = (-height * 6 / 4, 0)
if floating != false {
  let offset = (height * 1 / 8, 0)
  right = sum(right, offset)
  left = sum(left, offset)

  let floating-right = (-height * 6.5 / 8, width * 3 / 7)
  let floating-left = (-height * 6.5 / 8, -width * 3 / 7)
  if floating == true {
    wire(floating-right, floating-left)
  }
  else {
    wire(floating-left, sum(floating-right, (0, -width / 7)), (-height * 5.5 / 8, width * 2.5 / 7), floating-right)
  }
}

anchor("d", drain)
anchor("s", source)
anchor("g", gate-top)

swire(drain, right, left, source)
wire(gate-right, gate-left)
if channel == "p" {
  circle((-height * 4.5 / 4, 0), radius: height * 0.5 / 4, fill: style.fill, name: "c", stroke: 0.5pt)
}
wire(gate-center, gate-top)

}
component("mosfet", name, node, draw: draw, ..params)
}

While I agree that i use symbols like the ones you drew up as well, I think adding these symbols would go against the philosophy of the project. (maybe not my place to say this)

Purely aesthetic symbol variations are therefore excluded, as this project is focusing on making the standard symbols visually excellent. This ensures your circuits will be understandable by anyone, anywhere. Of course, I know this might be a constraint, so Zap will always give you the freedom to create your own custom symbols. - https://zap.grangelouis.ch/#:~:text=Purely,symbols%2E

[l0uisgrange]

@jaehho @Pyrix25633 I've never seen these symbols, do you have references (e.g. name)?
Maybe we can find the standard version and put it in the library, if you two use these there is high probability something normalized exists.

P.S. this issue has been moved to https://codeberg.org/grangelouis/zap/issues/174

[Pyrix25633]

Well some are on Wikipedia
For the others I don't know, it's just how they are represented on many academic materials