This repository was archived by the owner on Apr 7, 2026. It is now read-only.
feat(vsource): Add configurable AC waveforms#191
Open
weiserhase wants to merge 1 commit intol0uisgrange:mainfrom
Open
feat(vsource): Add configurable AC waveforms#191weiserhase wants to merge 1 commit intol0uisgrange:mainfrom
weiserhase wants to merge 1 commit intol0uisgrange:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds waveform selection for AC sources, allowing them to render as sine, square, triangle, or sawtooth shapes instead of a fixed AC icon.
The new option is configurable through the existing source helper API, with aliases supported for common waveform names. I also updated the voltage source styling defaults and test fixtures to cover the new behavior.
Before/After Comparison