Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the dbprovider's monitoring infrastructure by migrating from direct fetch calls to legacy monitor services to the new sealos-metrics-sdk. The implementation replaces the deprecated MONITOR_URL-based approach with a type-safe SDK that directly queries Victoria Metrics with built-in Kubernetes authentication.
Changes:
- Replaced direct HTTP fetch in
handleStream.tswithMetricsClientfrom sealos-metrics-sdk - Updated environment variables from
MONITOR_URLtoMETRICS_URLwith sensible defaults - Added
WHITELIST_KUBERNETES_HOSTSconfiguration for development flexibility
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/providers/dbprovider/src/services/handleStream.ts | Refactored to use MetricsClient SDK with helper functions for parameter normalization and type-safe database queries |
| frontend/providers/dbprovider/package.json | Added sealos-metrics-sdk workspace dependency |
| frontend/providers/dbprovider/deploy/manifests/deploy.yaml.tmpl | Updated environment variables to use METRICS_URL and WHITELIST_KUBERNETES_HOSTS with proper defaults |
| frontend/providers/dbprovider/deploy/Kubefile | Updated ENV declarations for metrics configuration with Victoria Metrics default URL |
| frontend/providers/dbprovider/.env.template | Documented new METRICS_URL and WHITELIST_KUBERNETES_HOSTS environment variables with usage examples |
| frontend/pnpm-lock.yaml | Added sealos-metrics-sdk dependency link and cleaned up unused transitive dependencies |
Files not reviewed (1)
- frontend/pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.