Open
Conversation
- Introduced GPU inventory data structure and related types for better management. - Updated the Devbox creation page to utilize GPU inventory for selection and validation. - Enhanced GPU component to display available models and specifications. - Implemented logic for GPU pod configuration and resource limits. - Added validation for GPU specifications and improved error messaging. - Updated API schemas to include GPU model, spec type, and pod configuration details. - Enhanced price calculation logic to account for GPU specifications and limits. This update improves the user experience when configuring GPU resources in the Devbox, ensuring accurate representation and management of GPU capabilities.
- Enhanced the normalization function to support additional fields for GPU specifications, including specType, specMemory, and specValue. - Updated stock retrieval to consider multiple potential properties (stock, available, count) for better accuracy. These changes ensure more robust handling of GPU resource data in the Devbox, improving inventory management and user experience.
- Removed dependency on GPU inventory configuration for enabling GPU features. - Streamlined the logic to determine if GPU features are enabled based solely on the environment variable. This change simplifies the handling of GPU features in the resource price API, ensuring a more straightforward implementation.
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-v5.1 #6846 +/- ##
===============================================
Coverage ? 61.86%
===============================================
Files ? 8
Lines ? 653
Branches ? 0
===============================================
Hits ? 404
Misses ? 202
Partials ? 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the user experience when configuring GPU resources in the Devbox, ensuring accurate representation and management of GPU capabilities.