Open
Conversation
Signed-off-by: Tingmao Wang <m@maowtm.org>
Signed-off-by: Tingmao Wang <m@maowtm.org>
Signed-off-by: Tingmao Wang <m@maowtm.org>
d286c76 to
9989713
Compare
Signed-off-by: Tingmao Wang <m@maowtm.org>
- Move TAP functions to a separate `tap.fish` file - Add `test_operators` to test `&&` and `||` parsing - Update name of mock profiles to be more conventional - Change some test messages - Handle multiline buffers correctly in commandline mock Signed-off-by: Tingmao Wang <m@maowtm.org>
9989713 to
e04fe88
Compare
Signed-off-by: Tingmao Wang <m@maowtm.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this I think the experience is fairly similar to the zsh case, with similar limitations, e.g. no command substitution, but also no automatic alias expansion yet due to alias actually being functions, rather than something we can just query.
There is also a caveat regarding pipelines (see third commit), and I'm not sure how best to handle it.
Demo:
Automatic insertion of
island runfor absolute path:abbrexpansion (I typedgp, then pressed enter twice (required to press enter twice due to limitation))Closes: #6