Skip to content

[13.x] Ensure DevCommands doesnt stop itself from registering#60526

Merged
taylorotwell merged 2 commits into
laravel:13.xfrom
jackbayliss:13.x-save-dev-command
Jun 16, 2026
Merged

[13.x] Ensure DevCommands doesnt stop itself from registering#60526
taylorotwell merged 2 commits into
laravel:13.xfrom
jackbayliss:13.x-save-dev-command

Conversation

@jackbayliss

@jackbayliss jackbayliss commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Closes #60525

This done broke me upgrade, because laravel framework itself is in vendor, it stops itself from registering dev commands which breaks composer updating... (see issue for log)

right now all new installs and upgrades fail cus of this

All this PR does is manually add them into commands array, rather than call the methods which avoids the vendor check, which means it works.

Tested locally:

artisan dev

[server] php artisan serve --host=localhost
[queue]  php artisan queue:listen --tries=1 --timeout=0
[logs]   php artisan pail --timeout=0
[vite]   bun run dev

[vite] $ vite
[vite] 3:42:15 PM [vite] (client) Re-optimizing dependencies because lockfile has changed
[vite] 
[vite]   VITE v8.0.14  ready in 297 ms
[vite] 
[vite]   ➜  Local:   https://localhost:5173/
[vite]   ➜  Network: https://172.18.0.8:5173/
[vite] 
[vite]   LARAVEL v13.16.0  plugin v3.1.0
[vite] 
[vite]   ➜  APP_URL: https://local.xxxxxx.com
[queue] 
[queue]    INFO  Processing jobs from the [default] queue.  
[queue] 
[logs]

Granted there could be a nicer way, but thought i'd throw something up cause.. its broken

@github-actions

Copy link
Copy Markdown

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@jackbayliss jackbayliss marked this pull request as ready for review June 16, 2026 15:45
@taylorotwell taylorotwell merged commit 4c969f5 into laravel:13.x Jun 16, 2026
53 checks passed
@jackbayliss jackbayliss deleted the 13.x-save-dev-command branch June 16, 2026 16:10
@jasonmccreary

Copy link
Copy Markdown
Contributor

@jackbayliss, nice, quick patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to upgrade due to DevCommands

3 participants