Fix DevCommands vendor registration check skipping userland frames#60538
Open
joetannenbaum wants to merge 3 commits into
Open
Fix DevCommands vendor registration check skipping userland frames#60538joetannenbaum wants to merge 3 commits into
joetannenbaum wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendor prevention check was comparing
$class === self::classto skip internal frames, but in PHP backtraces$frame["class"]is the class being called, not the caller. So when userland code (e.g. AppServiceProvider) callsDevCommands::register(), the frame has the userland file butDevCommandsas the class, causing it to be skipped. This meant legitimate userland registrations could be incorrectly rejected.Switches to
$file === __FILE__so we only skip frames that physically originate from DevCommands.php.