When formatting provided site name, only remove .tld if it's at the end#1297
Merged
mattstauffer merged 3 commits intolaravel:masterfrom Dec 1, 2022
Merged
Conversation
ErikDohmen
force-pushed
the
bugfix/1295-fix-tld-removal-only-if-at-end
branch
from
0b3cbbf to
9e3a262
Compare
o check if tld is at the end of the site name and if so remove it o added corresponding test
ErikDohmen
force-pushed
the
bugfix/1295-fix-tld-removal-only-if-at-end
branch
from
9e3a262 to
2d429c3
Compare
This was referenced Nov 2, 2022
mattstauffer
requested changes
Nov 10, 2022
Collaborator
mattstauffer
left a comment
mattstauffer
left a comment
There was a problem hiding this comment.
Just one small refactor and then this is good to go!
mattstauffer
changed the title
Co-authored-by: Matt Stauffer <mattstauffer@users.noreply.github.com>
Contributor
Author
|
@mattstauffer, thanks for the suggestion. I added it and added one more missing ) in your code suggestion to make it work. |
Collaborator
|
Thanks @ErikDohmen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(copied from Issue #1298 for context):
Description:
TL;DR: If your site name contains your TLD (e.g. if your TLD is
.testand your site name contains.test) it will be removed inappropriately.In line with our regular site setup we have the same locally with valet:
The moment it goes wrong is when I try to use the
isolateoption. Then I get an error:portal-work isn't found as site name. That is correct as it is indeedportal.test-work. The problem seems to be that.testis removed not just at the end, but just as it is found in the site name.Searches on internet doesn't bring any solutions to the table.
Steps To Reproduce:
portal.test-workSolutions in this PR:
Fixes #1295, Fixes #1298.