Extract Server class and refactor loading of drivers#1319
Merged
mattstauffer merged 7 commits intoversion-4from Dec 18, 2022
Merged
Extract Server class and refactor loading of drivers#1319mattstauffer merged 7 commits intoversion-4from
mattstauffer merged 7 commits intoversion-4from
Conversation
- Extract much of server.php into a `Server` class - Move all but the Laravel and Basic drivers into a subfolder - Load all but the Laravel and Basic drivers via glob - Add `beforeLoading` hook to simplify the `frontControllerPath` method for some drivers
…nto mes/extract-server-class
Merged
Member
|
@mattstauffer if we're going to add type hints might as well remove all docblock params and return types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mega PR. Oops. :)
BasicandLaravelinto aSpecificdirectory so they can be loaded via globbeforeLoadinghook to simplify thefrontControllerPathmethod of many drivers