Fixes permission denied check when result starts with 'Permission denied'#1343
Merged
mattstauffer merged 1 commit intolaravel:masterfrom Jan 13, 2023
matthewjohns0n:master
Merged
Fixes permission denied check when result starts with 'Permission denied'#1343mattstauffer merged 1 commit intolaravel:masterfrom matthewjohns0n:master
mattstauffer merged 1 commit intolaravel:masterfrom
matthewjohns0n:master
Conversation
Collaborator
|
Great, thanks! and yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a certificate, if the result of the command starts with "Permission denied" it doesn't know that the permission was denied, so it doesn't try to run as root.
The current check will only work if the result contains "Permission denied" but will fail if the result starts with "Permission denied" since that will return
0.I also wasn't sure which branch to PR this into, but it looks like
masteris typically where things get PR'd into. Let me know if it needs to be into a different branch and I can change it.