Add php isolation from link command#1360
Merged
mattstauffer merged 2 commits intolaravel:masterfrom Feb 13, 2023
Merged
Conversation
mattstauffer
reviewed
Feb 9, 2023
|
|
||
| if ($secure) { | ||
| $this->runCommand('secure '.$name); | ||
| $this->runCommand('secure'); |
Collaborator
There was a problem hiding this comment.
What's the benefit of dropping $name here?
Contributor
Author
There was a problem hiding this comment.
@mattstauffer the code behind $this->runCommand() doesn't use anything after the first space character in the command declaration... Which is why I didn't call that method when adding --isolate because specifying a PHP version via string concatenation didn't get passed through 🫠
Collaborator
|
Thanks @joelbutcher! |
mattstauffer
added a commit
that referenced
this pull request
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
valet linkcommand by adding an--isolateoption to allow users to link, secure and isolate a site in one command.Before
valet link --secure && valet isolateAfter
Please note that the
--isolateoption requires a.valetphprcfile in the projects root directory as I could not get$this->runCommandto accept any additional arguments / options.