Skip to content

Update php and composer commands to allow passing in specific site#1370

Merged
mattstauffer merged 1 commit intomasterfrom
mes/php-site-param
Feb 19, 2023
Merged

Update php and composer commands to allow passing in specific site#1370
mattstauffer merged 1 commit intomasterfrom
mes/php-site-param

Conversation

@mattstauffer
Copy link
Copy Markdown
Collaborator

@mattstauffer mattstauffer commented Feb 17, 2023

Closes #1367.

E.g., to run this command:

valet php -v

When you've linked a site using a name other than the directory name; for example:

cd /tmp
mkdir my-site
cd my-site
valet link different-name-than-folder
valet isolate different-name-than-folder php@8.0

This PR allows you to run this:

valet php --site=different-name-than-folder -v

Comment thread cli/app.php
Comment thread cli/app.php
@scrummitch
Copy link
Copy Markdown

Working locally for me, test output here:

#1367 (comment)

@mattstauffer mattstauffer merged commit 9782d48 into master Feb 19, 2023
@mattstauffer mattstauffer deleted the mes/php-site-param branch February 19, 2023 02:46
mattstauffer added a commit that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

valet php can't be defined to run on a site linked to a name different than its directory

3 participants