[v4] Fix ngrok.io proxy/forwarding detection#1404
Merged
mattstauffer merged 1 commit intolaravel:masterfrom Apr 26, 2023
Merged
[v4] Fix ngrok.io proxy/forwarding detection#1404mattstauffer merged 1 commit intolaravel:masterfrom
mattstauffer merged 1 commit intolaravel:masterfrom
Conversation
Fixes laravel#1384 Since Valet 4 uses Ngrok v3, this change is needed to accommodate the change ngrok made: > In ngrok v3 the `X-Original-Host` header was replaced with the more standard `X-Forwarded-Host` to better align with web standards. > More Info: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host Credit to @streamingsystems for doing the legwork. Co-authored-by: streamingsystems <streamingsystems@users.noreply.github.com>
Collaborator
|
Fantastic, thank you @streamingsystems and @drbyte! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1384
Since Valet 4 uses Ngrok v3, this change is needed to accommodate the change ngrok made:
Credit to @streamingsystems for doing the legwork.