Skip to content

Ignore invalid paths#1478

Merged
driesvints merged 1 commit intolaravel:masterfrom
ahmedash95:fix-invalid-paths
May 7, 2024
Merged

Ignore invalid paths#1478
driesvints merged 1 commit intolaravel:masterfrom
ahmedash95:fix-invalid-paths

Conversation

@ahmedash95
Copy link
Copy Markdown
Contributor

Why?

While removing a directory that is parked in Valet. I encountered an error originating from Herd's Valet, though the issue lies with Valet itself. And from a user's perspective, I believe Valet should remain operational even if one of the paths is invalid

image

Suggestion

Introducing a command such as valet check would be beneficial. It could report on Valet's status, confirming if all paths are correct or if any path is invalid.

@drbyte
Copy link
Copy Markdown
Contributor

drbyte commented Apr 1, 2024

I agree with this code change.

For cleanup, perhaps the valet paths command could offer to cleanup any invalid paths when it displays the ones it has registered. I'd support a PR or discussion for implementing that.

@driesvints driesvints merged commit 0f3ab1f into laravel:master May 7, 2024
@driesvints
Copy link
Copy Markdown
Member

Thanks!

@ahmedash95 ahmedash95 deleted the fix-invalid-paths branch May 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants