Add the ability to renew the Certificate Authority certificate#1498
Merged
mattstauffer merged 2 commits intolaravel:masterfrom Dec 10, 2024
Merged
Add the ability to renew the Certificate Authority certificate#1498mattstauffer merged 2 commits intolaravel:masterfrom
mattstauffer merged 2 commits intolaravel:masterfrom
Conversation
Collaborator
|
Thanks @adrum! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to renew the Certificate Authority certificate optionally when running the
valet renew --cacommand. Additionally, it adds the ability to view the CA certificate's expiration date throughvalet secured --ca.This should resolve the issue highlighted in #1496. It may also resolve #1487, but I don't think I was able to verify if the CA expired.
My comment here summarizes the scenario pretty well how users may experience this issue, but I would wager to guess it should be an increasingly uncommon scenario, given new CAs should have 20 years of validity.