Set files path as a static path for concrete5 driver#514
Set files path as a static path for concrete5 driver#514mattstauffer merged 2 commits intolaravel:masterfrom
Conversation
Previously testing a concrete5 site that had tons of 404s and required file based sessions would force each request to load sequentially causing the site to load pretty slowly. This change makes it so that the driver is aware of the files directory and markes anything within as a static file.
|
@KorvinSzanto Could you ask a few other concrete5 folks to check this out for you, and give us emoji responses so we can verify it's working for multiple folks? None of us use concrete5 so we can't check this. |
|
What is the specification on $uri ? Is it site relative, or host relative? If host relative, testing ===0 could have issues with installations in sub-folders. |
|
This helps me a lot for sites which have lots of 404s. |
|
If we can get more concrete5 folks to check it, we could merge this, but it's been four years since I asked for more input so I'm gonna close it. |
|
I did have folks weigh in as evidenced by the emoji responses so I'm not tracking on what was missing. I'm guessing you were hoping for more than 5 or so people? |
|
@KorvinSzanto To be honest, I was looking for comments and didn't even check the emoji responses :) Please feel free to re-make the PR if you'd like. |
|
I've restored the branch so this PR should be reopenable. If not I can go ahead and make a new PR |
|
@KorvinSzanto Thanks! i just did a merge resolution; can you verify it still works correctly after that? |
Previously, testing a concrete5 site that had tons of 404s and required file based sessions would force each request to load sequentially causing the site to load pretty slowly. This change makes it so that the driver is aware of the files directory and markes anything within as a static file.