Disable brew auto cleanup on installation, to avoid upgrade errors failing install#995
Merged
mattstauffer merged 2 commits intolaravel:masterfrom Dec 2, 2022
Merged
Conversation
Collaborator
|
Tests fail after this. I'll probably work to update the tests later. |
Contributor
Author
|
I totally forgot about this pull request :O thank you very much for still looking into it :) |
Collaborator
|
Thanks for this PR! |
Contributor
Author
|
Thank you for merging it :) and updating it to an updated php version :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you change the php version and brew stumbles in auto cleanup mode which can fail but is unrelated to the version change in that case. So I just added the environment variable to these calls.