Skip to content

Disable brew auto cleanup on installation, to avoid upgrade errors failing install#995

Merged
mattstauffer merged 2 commits intolaravel:masterfrom
JoshuaBehrens:patch-1
Dec 2, 2022
Merged

Disable brew auto cleanup on installation, to avoid upgrade errors failing install#995
mattstauffer merged 2 commits intolaravel:masterfrom
JoshuaBehrens:patch-1

Conversation

@JoshuaBehrens
Copy link
Copy Markdown
Contributor

When you change the php version and brew stumbles in auto cleanup mode which can fail but is unrelated to the version change in that case. So I just added the environment variable to these calls.

==> `brew cleanup` has not been run in 30 days, running now...
Removing: /usr/local/Cellar/krb5/1.18.2... (162 files, 4.0MB)
Removing: /usr/local/Cellar/oniguruma/6.9.5-rev1... (16 files, 1.3MB)
Error: Could not remove php keg! Do so manually:
  sudo rm -rf /usr/local/Cellar/php/7.4.9
Removing: /usr/local/Cellar/php/7.4.9... (497 files, 72.2MB)


In Brew.php line 140:
                                         
  Brew was unable to install [php@7.4].  
                                         

use <phpVersion>

@mattstauffer
Copy link
Copy Markdown
Collaborator

Tests fail after this. I'll probably work to update the tests later.

@JoshuaBehrens
Copy link
Copy Markdown
Contributor Author

I totally forgot about this pull request :O thank you very much for still looking into it :)

@mattstauffer mattstauffer merged commit 5b3433e into laravel:master Dec 2, 2022
@mattstauffer
Copy link
Copy Markdown
Collaborator

Thanks for this PR!

@mattstauffer mattstauffer changed the title Disable brew auto cleanup on installation Disable brew auto cleanup on installation, to avoid upgrade errors failing install Dec 2, 2022
@JoshuaBehrens
Copy link
Copy Markdown
Contributor Author

JoshuaBehrens commented Dec 2, 2022

Thank you for merging it :) and updating it to an updated php version :)

@JoshuaBehrens JoshuaBehrens deleted the patch-1 branch December 2, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants