[docs] Clarify change in date-formats#725
Merged
lcobucci merged 1 commit intolcobucci:4.2.xfrom Apr 27, 2021
jaylinski:patch-1
Merged
[docs] Clarify change in date-formats#725lcobucci merged 1 commit intolcobucci:4.2.xfrom jaylinski:patch-1
lcobucci merged 1 commit intolcobucci:4.2.xfrom
jaylinski:patch-1
Conversation
lcobucci
requested changes
Apr 27, 2021
Owner
lcobucci
left a comment
lcobucci
left a comment
There was a problem hiding this comment.
Just a teeny tiny thing.
Thanks for your contribution @jaylinski!
| 1. Token configuration methods were renamed | ||
| 1. Signature is created via `Builder#getToken()` (instead of `Builder#sign()`) | ||
| 1. `DateTimeImmutable` objects are now for the registered claims with dates | ||
| 1. `DateTimeImmutable` objects are now used for the registered claims with dates and will use microtime instead of unix timestamps |
Owner
There was a problem hiding this comment.
I like the explicitness here, just think that we can improve the construction. What do you think about this:
Suggested change
| 1. `DateTimeImmutable` objects are now used for the registered claims with dates and will use microtime instead of unix timestamps | |
| 1. `DateTimeImmutable` objects are now used for the registered claims with dates, which are by default encoded as floats with microseconds as precision |
Contributor
Author
There was a problem hiding this comment.
I think it is much better. 👍 I pushed the changes.
Related to #710
lcobucci
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently upgraded a project to
lcobucci/jwt:4.1. My issue was that tokens generated by v4 were rejected by the v3 version of this library, because theiat-claim validation always failed.I could solve this issue by using the method described in this PR.
I'm not sure what caused this issue, but I guess it was leeway-related.
Related to #710