This repository was archived by the owner on Feb 8, 2024. It is now read-only.
intrinsics.di: add support for LLVM 11.1#195
Merged
JohanEngelen merged 1 commit intoldc-developers:ldcfrom Feb 18, 2021
Merged
Conversation
Member
|
great, thanks. |
mitchblank
added a commit
to mitchblank/ldc
that referenced
this pull request
Feb 19, 2021
Author
|
OK done: ldc-developers/ldc#3671 Hopefully I did it right; I'm not too much of a git submodules expert! |
mitchblank
added a commit
to mitchblank/homebrew-core
that referenced
this pull request
Feb 19, 2021
Two changes are required: * The intrinsics.di need a one-line adjustment to recognize LLVM 11.1 as a valid version. This is already merged into the upstream HEAD but we need to adjust the patch a little when applying against the 1.24.0 tarball: ldc-developers/druntime#195 * As @bayandin discovered when trying to make this change a few months ago, "brew test" failed due to a loading problem with libLTO-ldc.dylib Homebrew#61117 (comment) I debugged this to a problem with it finding libLLVM.dylib correctly. I filed this upstream as ldc-developers/ldc#3670 but in the meantime we can just copy the library as a workaround.
JohanEngelen
pushed a commit
to ldc-developers/ldc
that referenced
this pull request
Feb 19, 2021
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Feb 19, 2021
Two changes are required: * The intrinsics.di need a one-line adjustment to recognize LLVM 11.1 as a valid version. This is already merged into the upstream HEAD but we need to adjust the patch a little when applying against the 1.24.0 tarball: ldc-developers/druntime#195 * As @bayandin discovered when trying to make this change a few months ago, "brew test" failed due to a loading problem with libLTO-ldc.dylib #61117 (comment) I debugged this to a problem with it finding libLLVM.dylib correctly. I filed this upstream as ldc-developers/ldc#3670 but in the meantime we can just copy the library as a workaround. Closes #71460. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this building ldc against llvm 11.1 fails immediately. I'm not an LLVM expert but it seems OK once I added this.