Skip to content

Pathfinding improvements for bridges#11698

Merged
Raycoms merged 3 commits into
version/mainfrom
pathfindingbridges
Jun 7, 2026
Merged

Pathfinding improvements for bridges#11698
Raycoms merged 3 commits into
version/mainfrom
pathfindingbridges

Conversation

@someaddons

Copy link
Copy Markdown
Contributor

Checklist

  • [x ] I have read and accept the Contributing Guidelines
  • [ x] I have tested and confirmed my changes are working on the most recent commit of this pull request
  • [x ] I have used AI in the creation of this pull request (better max node limit calc)

Related issues

Closes #
Closes #

Changes proposed in this pull request

  • Removed old pathfinding debug config
  • Removed pathfinding core count config
  • Add new pathfinding config, allowing high max node limits at the sake of performance
  • Improved pathfinding to make citizens better at finding bridges, swim nodes are now also more expensive
  • Prevent random buildings containing stash or postbox

Review please

Add new pathfinding config, allowing high max node limits at the sake of performance
Improved pathfinding to make citizens better at finding bridges
Thodor12
Thodor12 previously approved these changes Jun 4, 2026
Comment thread src/main/resources/assets/minecolonies/lang/manual_en_us.json Outdated
if (executor == null)
{
executor = new ThreadPoolExecutor(1, MineColonies.getConfig().getServer().pathfindingMaxThreadCount.get(), 10, TimeUnit.SECONDS, jobQueue, new MinecoloniesThreadFactory());
executor = new ThreadPoolExecutor(1, 1, 10, TimeUnit.SECONDS, jobQueue, new MinecoloniesThreadFactory());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't allow multiple threads anymore?

Co-authored-by: Thom van den Akker <thodor20@gmail.com>
@Raycoms Raycoms merged commit 673013c into version/main Jun 7, 2026
1 check passed
@Raycoms Raycoms deleted the pathfindingbridges branch June 7, 2026 12:43
Raycoms added a commit that referenced this pull request Jun 7, 2026
* Removed old pathfinding debug config
Add new pathfinding config, allowing high max node limits at the sake of performance
Improved pathfinding to make citizens better at finding bridges

* Prevent random buildings containing stash or postbox

* Update src/main/resources/assets/minecolonies/lang/manual_en_us.json

Co-authored-by: Thom van den Akker <thodor20@gmail.com>

---------

Co-authored-by: Raycoms <ray.neiheiser@gmail.com>
Co-authored-by: Thom van den Akker <thodor20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants