-
Notifications
You must be signed in to change notification settings - Fork 142
feat: lemmas about Nat.toDigits
#1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
350f301
feat: add lemma connecting `Nat.toDigits` and `Char.isDigit`
marcusrossel ce5f26d
Strengthen lemma
marcusrossel f962db7
Change `isDigit_digitChar_iff_lt` to `isDigit_digitChar`
marcusrossel a44eb80
Add two additional lemmas
marcusrossel b94c5e8
Fix namespace
marcusrossel 6cfbd0d
Remove redundant lemma
marcusrossel 1b340c9
Implement @eric-wieser's generalization
marcusrossel 8dd7a28
Generalize theorem
marcusrossel 3694549
Fix theorem name
marcusrossel 2800e1a
Add proof of `toDigits_append_toDigits`
marcusrossel 73018bb
Add proof of
marcusrossel b8ed3cc
Remove unnecessary assumptions
marcusrossel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import Batteries.Data.Nat.Basic | ||
| import Batteries.Data.Nat.Bisect | ||
| import Batteries.Data.Nat.Digits | ||
| import Batteries.Data.Nat.Gcd | ||
| import Batteries.Data.Nat.Lemmas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /- | ||
| Copyright (c) 2025 Marcus Rossel. All rights reserved. | ||
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Marcus Rossel | ||
| -/ | ||
|
|
||
| namespace Nat | ||
|
|
||
| @[simp] | ||
| theorem isDigit_digitChar : n.digitChar.isDigit = decide (n < 10) := | ||
| match n with | ||
| | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 => by simp [digitChar] | ||
| | _ + 10 => by | ||
| simp only [digitChar, ↓reduceIte, Nat.reduceEqDiff] | ||
| (repeat' split) <;> simp | ||
|
|
||
| private theorem isDigit_of_mem_toDigitsCore_10 | ||
| (hf : n < fuel) (hc : c ∈ cs → c.isDigit) (h : c ∈ toDigitsCore 10 fuel n cs) : | ||
| c.isDigit := by | ||
| induction fuel generalizing n cs <;> rw [toDigitsCore] at h | ||
| next => contradiction | ||
| next fuel ih => | ||
| split at h | ||
| case' isFalse => apply ih (by omega) (fun h => ?_) h | ||
| all_goals | ||
| cases h | ||
| next => simp [mod_lt] | ||
| next hm => exact hc hm | ||
|
|
||
| theorem isDigit_of_mem_toDigits_10 (h : c ∈ toDigits 10 n) : c.isDigit := | ||
| isDigit_of_mem_toDigitsCore_10 (Nat.lt_succ_self _) (fun _ => by contradiction) h | ||
|
|
||
| theorem toDigits_10_of_lt_10 (h : n < 10) : toDigits 10 n = [n.digitChar] := | ||
| match n with | ||
| | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 => by decide | ||
| | _ + 10 => by contradiction | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.