[Merged by Bors] - feat: extend pp.links to support Pi, Prop, Type, and Sort#778
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - feat: extend pp.links to support Pi, Prop, Type, and Sort#778eric-wieser wants to merge 3 commits intomasterfrom
pp.links to support Pi, Prop, Type, and Sort#778eric-wieser wants to merge 3 commits intomasterfrom
Conversation
This uses `U+E003` (the next available private use character) to prefix the names: * `pi` * `forall` * `function` * `implies` * `Sort` * `Prop` * `Type` The motivation is to be able to link these ideas in doc-gen.
eric-wieser
force-pushed
the
eric-wieser/builtin-links
branch
from
55a0032 to
ab29f49
Compare
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
This uses `U+E003` (the next available private use character after the ones claimed in #89) to prefix the names: * `pi` * `forall` * `function` * `implies` * `Sort` * `Prop` * `Type` The motivation is to be able to link these ideas in doc-gen.
Member
|
Thanks! |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
pp.links to support Pi, Prop, Type, and Sortpp.links to support Pi, Prop, Type, and Sort
Member
Author
|
Mind looking at the related leanprover-community/doc-gen#173 too? |
Member
|
The doc-gen PR is also a 👍 from me, but we'll first need to bump mathlib to 3.49. leanprover-community/mathlib3#17470 |
Member
Author
|
The doc-gen PR doesn't need a lean bump |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses
U+E003(the next available private use character after the ones claimed in #89) to prefix the names:piforallfunctionimpliesSortPropTypeThe motivation is to be able to link these ideas in doc-gen.