Skip to content

[Merged by Bors] - feat: TendstoUniformlyOn for tprod's#13349

Closed
CBirkbeck wants to merge 132 commits intomasterfrom
infinite_prod_one_add
Closed

[Merged by Bors] - feat: TendstoUniformlyOn for tprod's#13349
CBirkbeck wants to merge 132 commits intomasterfrom
infinite_prod_one_add

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator

@CBirkbeck CBirkbeck commented May 29, 2024

@CBirkbeck CBirkbeck added the WIP Work in progress label May 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 10, 2024

PR summary 27f6a0ab63

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.SpecialFunctions.Log.Summable 2278 2277 -1 (-0.04%)
Import changes for all files
Files Import difference
Mathlib.Analysis.SpecialFunctions.Log.Summable -1
Mathlib.Topology.Algebra.InfiniteSum.UniformOn 1
Mathlib.Topology.Algebra.IsUniformGroup.Order (new file) 1033
Mathlib.Analysis.NormedSpace.MultipliableUniformlyOn (new file) 2281

Declarations diff

+ HasProdUniformlyOn.hasProdLocallyUniformlyOn
+ HasProdUniformlyOn.tendstoUniformlyOn_finset_range
+ Summable.hasSumUniformlyOn_log_one_add
+ Summable.tendstoUniformlyOn_tsum_nat_log_one_add
+ TendstoUniformlyOn.comp_cexp
+ TendstoUniformlyOn.eventually_forall_le
+ TendstoUniformlyOn.eventually_forall_lt
+ UniformContinuousOn.comp_tendstoUniformlyOn_eventually
+ hasProdLocallyUniformlyOn_nat_one_add
+ hasProdLocallyUniformlyOn_of_forall_compact
+ hasProdLocallyUniformlyOn_one_add
+ hasProdUniformlyOn_nat_one_add
+ hasProdUniformlyOn_of_clog
+ hasProdUniformlyOn_one_add
+ multipliableLocallyUniformlyOn_nat_one_add
+ multipliableLocallyUniformlyOn_one_add
+ multipliableUniformlyOn_nat_one_add
+ multipliableUniformlyOn_of_clog
+ multipliableUniformlyOn_one_add
+ tendstoUniformlyOn_iff_restrict
- Complex.tendstoUniformlyOn_tsum_nat_log_one_add

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments on the files in Topology/. Will look at the analysis files later.

Comment thread Mathlib/Topology/UniformSpace/UniformConvergence.lean Outdated
Comment thread Mathlib/Topology/UniformSpace/UniformConvergenceTopology.lean Outdated
Comment thread Mathlib/Topology/UniformSpace/UniformConvergenceTopology.lean Outdated
Comment thread Mathlib/Topology/UniformSpace/UniformConvergenceTopology.lean Outdated
Comment thread Mathlib/Topology/Algebra/InfiniteSum/UniformOn.lean Outdated
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started writing a review and then realised that I had forgotten to update to your latest commits first. Here is what I had up to that point.

Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this through!

Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
Comment thread Mathlib/Analysis/NormedSpace/MultipliableUniformlyOn.lean Outdated
@loefflerd
Copy link
Copy Markdown
Contributor

I spotted a few typos which I had overlooked previously (and some golfs in the code which I suggested) so I fixed them and pushed them to your branch. I think this is good now. Thanks for your patience with this!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 29, 2025
@CBirkbeck
Copy link
Copy Markdown
Collaborator Author

No thank you for all the help!

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 2, 2025
Give conditions for prods to converge uniformly to a tprod.



Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 2, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: TendstoUniformlyOn for tprod's [Merged by Bors] - feat: TendstoUniformlyOn for tprod's Jun 2, 2025
@mathlib-bors mathlib-bors bot closed this Jun 2, 2025
@mathlib-bors mathlib-bors bot deleted the infinite_prod_one_add branch June 2, 2025 15:41
joelriou pushed a commit that referenced this pull request Jun 8, 2025
Give conditions for prods to converge uniformly to a tprod.



Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
TOMILO87 pushed a commit that referenced this pull request Jun 8, 2025
Give conditions for prods to converge uniformly to a tprod.



Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
Give conditions for prods to converge uniformly to a tprod.



Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants