Skip to content

[Merged by Bors] - feat(QuotientGroup): surjectivity and kernel of QuotientGroup.map#23205

Closed
xroblot wants to merge 8 commits intomasterfrom
xfr_quotientgroup_rangeker
Closed

[Merged by Bors] - feat(QuotientGroup): surjectivity and kernel of QuotientGroup.map#23205
xroblot wants to merge 8 commits intomasterfrom
xfr_quotientgroup_rangeker

Conversation

@xroblot
Copy link
Copy Markdown
Collaborator

@xroblot xroblot commented Mar 21, 2025

Prove formulas for the kernel of QuotientGroup.lift and QuotientGroup.map and that these maps are surjective if the corresponding functions are surjective.


Open in Gitpod

@xroblot xroblot changed the title feat(QuotientGroup): subjectivity and kernel of QuotientGroup.map feat(QuotientGroup): surjectivity and kernel of QuotientGroup.map Mar 21, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2025

PR summary 652a2ba699

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Quotient.lift_surjective
+ Quotient.lift_surjective_iff
+ ker_lift
+ ker_map
+ ker_toSubmonoid
+ lift_comp_mk'
+ lift_surjective_of_surjective
+ map_comap_eq_self_of_surjective
+ map_surjective_of_surjective
+ map_toSubmonoid

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Mar 21, 2025
Comment thread Mathlib/GroupTheory/QuotientGroup/Defs.lean Outdated
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Mar 24, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2025
Comment thread Mathlib/GroupTheory/QuotientGroup/Defs.lean Outdated
Comment thread Mathlib/GroupTheory/QuotientGroup/Defs.lean Outdated
Comment thread Mathlib/GroupTheory/QuotientGroup/Defs.lean
Comment thread Mathlib/GroupTheory/QuotientGroup/Defs.lean
@urkud urkud added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 28, 2025
@urkud
Copy link
Copy Markdown
Member

urkud commented Apr 28, 2025

Thanks! Once you address these comments, please tag me, and I'll try to quickly review&merge the new version.

@xroblot
Copy link
Copy Markdown
Collaborator Author

xroblot commented Apr 29, 2025

@urkud The new version is ready for your review. Thanks!

@xroblot xroblot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 29, 2025
Comment thread Mathlib/Data/Quot.lean
@urkud
Copy link
Copy Markdown
Member

urkud commented Apr 29, 2025

Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 29, 2025

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 29, 2025
@xroblot
Copy link
Copy Markdown
Collaborator Author

xroblot commented Apr 30, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 30, 2025
…23205)

Prove formulas for the kernel of `QuotientGroup.lift` and `QuotientGroup.map` and that these maps are surjective if the corresponding functions are surjective.
 


Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 30, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(QuotientGroup): surjectivity and kernel of QuotientGroup.map [Merged by Bors] - feat(QuotientGroup): surjectivity and kernel of QuotientGroup.map Apr 30, 2025
@mathlib-bors mathlib-bors bot closed this Apr 30, 2025
@mathlib-bors mathlib-bors bot deleted the xfr_quotientgroup_rangeker branch April 30, 2025 11:32
tannerduve pushed a commit that referenced this pull request May 13, 2025
…23205)

Prove formulas for the kernel of `QuotientGroup.lift` and `QuotientGroup.map` and that these maps are surjective if the corresponding functions are surjective.
 


Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants