chore: change prios of some normed ring to ring instances#24011
chore: change prios of some normed ring to ring instances#24011
Conversation
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Let's see whether this alone has an affect on the benchmark
|
!bench |
PR summary 95e3c54d89Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
Here are the benchmark results for commit d421df7. |
2 files, Instructions +2.0⬝10⁹
4 files, Instructions +1.0⬝10⁹
2 files, Instructions -2.0⬝10⁹
|
|
|
|
!bench |
|
Here are the benchmark results for commit 615938d. |
2 files, Instructions +2.0⬝10⁹
4 files, Instructions +1.0⬝10⁹
2 files, Instructions -2.0⬝10⁹
|
…buzzard-harmonise-normed-ring-prios
|
Now merging David's ideas (via Eric's #24003) to see if there's any difference. |
|
!bench |
|
Here are the benchmark results for commit 95e3c54. Benchmark Metric Change
===========================================================================
+ build parsing -5.6%
- ~Mathlib.Analysis.Analytic.Basic instructions 17.1%
- ~Mathlib.Analysis.Analytic.CPolynomialDef instructions 18.9%
- ~Mathlib.Analysis.Analytic.ChangeOrigin instructions 9.9%
- ~Mathlib.Analysis.Analytic.Constructions instructions 13.1%
- ~Mathlib.Analysis.Analytic.Inverse instructions 9.2%
- ~Mathlib.Analysis.Calculus.ContDiff.Basic instructions 11.4%
- ~Mathlib.Analysis.Calculus.ContDiff.Defs instructions 15.0%
- ~Mathlib.Analysis.Calculus.ContDiff.FTaylorSeries instructions 10.6%
- ~Mathlib.Analysis.Calculus.ContDiff.FaaDiBruno instructions 9.1%
- ~Mathlib.Analysis.Calculus.ContDiff.Operations instructions 15.4%
- ~Mathlib.Analysis.Calculus.Deriv.Basic instructions 12.9%
- ~Mathlib.Analysis.Calculus.Deriv.Mul instructions 10.2%
- ~Mathlib.Analysis.Calculus.FDeriv.Analytic instructions 7.0%
- ~Mathlib.Analysis.Calculus.FDeriv.Mul instructions 3.4%
- ~Mathlib.Analysis.Convolution instructions 5.8%
- ~Mathlib.Analysis.NormedSpace.Multilinear.Basic instructions 4.1%
- ~Mathlib.Analysis.NormedSpace.Multilinear.Curry instructions 5.2%
- ~Mathlib.Analysis.NormedSpace.OperatorNorm.Bilinear instructions 6.8%
- ~Mathlib.CategoryTheory.Sums.Products instructions 73.1%
+ ~Mathlib.Topology.Algebra.InfiniteSum.Constructions instructions -38.7% |
2 files, Instructions +31.0⬝10⁹
2 files, Instructions +21.0⬝10⁹
2 files, Instructions +19.0⬝10⁹
3 files, Instructions +11.0⬝10⁹
2 files, Instructions +10.0⬝10⁹
3 files, Instructions +9.0⬝10⁹
4 files, Instructions +5.0⬝10⁹
6 files, Instructions +4.0⬝10⁹
10 files, Instructions +3.0⬝10⁹
15 files, Instructions +2.0⬝10⁹
36 files, Instructions +1.0⬝10⁹
4 files, Instructions -2.0⬝10⁹
|
An attempt to make our priority 100 instance choices more consistent in
Analysis/Normed/Ring/Basic.lean.See Zulip