Skip to content

[Merged by Bors] - feat(NumberTheory/ModularForms): the Dedekind Eta function#28400

Closed
CBirkbeck wants to merge 35 commits intoleanprover-community:masterfrom
CBirkbeck:Dedekind_eta
Closed

[Merged by Bors] - feat(NumberTheory/ModularForms): the Dedekind Eta function#28400
CBirkbeck wants to merge 35 commits intoleanprover-community:masterfrom
CBirkbeck:Dedekind_eta

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator

@CBirkbeck CBirkbeck commented Aug 14, 2025

We define the Dedekind eta function in preparation for later relating it to Eisenstein series and the modular form Delta.


Open in Gitpod

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Aug 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2025

PR summary 2c4da570e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.ModularForms.DedekindEta (new file) 2409

Declarations diff

+ Summable.summable_log_norm_one_add
+ contDiff_qParam
+ differentiableAt_eta_of_mem_upperHalfPlaneSet
+ differentiable_qParam
+ eta
+ eta_ne_zero
+ eta_q
+ eta_q_eq_cexp
+ eta_q_eq_pow
+ isOpen_upperHalfPlaneSet
+ logDeriv_one_sub_cexp
+ logDeriv_one_sub_mul_cexp_comp
+ multipliableLocallyUniformlyOn_eta
+ one_sub_eta_q_ne_zero
+ qParam_ne_zero
+ summable_eta_q
+ tprod_one_add_ne_zero_of_summable
+ tsum_logDeriv_eta_q
+ upperHalfPlaneSet

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Aug 14, 2025
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Aug 14, 2025
@CBirkbeck CBirkbeck mentioned this pull request Aug 20, 2025
3 tasks
@CBirkbeck CBirkbeck marked this pull request as ready for review August 20, 2025 15:55
@CBirkbeck CBirkbeck requested a review from loefflerd August 20, 2025 16:04
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few quick thoughts (have to go get lunch now).

Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/Analysis/Complex/UpperHalfPlane/Basic.lean Outdated
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's it from me. Let's hope the mini-PR I spun off gets merged soon. Probably best I don't use my maintainer-merge powers until that has happened, but I will do so once it has (if I don't, remind me!)

Comment thread Mathlib/Analysis/SpecialFunctions/Log/Summable.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
@CBirkbeck CBirkbeck added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 22, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 22, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 22, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 22, 2025
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some more trivial fixes (mostly just formatting and golfs). Feel free to fix or ignore as you prefer.

maintainer delegate

Comment thread Mathlib/Analysis/Complex/UpperHalfPlane/Basic.lean
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
Comment thread Mathlib/NumberTheory/ModularForms/DedekindEta.lean Outdated
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 24, 2025
@YaelDillies YaelDillies changed the title Define the Dedekind Eta function feat: the Dedekind Eta function Aug 24, 2025
@loefflerd loefflerd changed the title feat: the Dedekind Eta function feat(NumberTheory/ModularForms): the Dedekind Eta function Aug 24, 2025
CBirkbeck and others added 3 commits August 25, 2025 09:30
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
@loefflerd
Copy link
Copy Markdown
Contributor

loefflerd commented Aug 25, 2025

Maintainers: I confirm all my comments are dealt with, so my "maintainer delegate" recommendation can become a "maintainer merge".

@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 25, 2025
mathlib-bors bot pushed a commit that referenced this pull request Aug 25, 2025
We define the Dedekind eta function in preparation for later relating it to Eisenstein series and the modular form Delta.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 25, 2025

Pull request successfully merged into master.

Build succeeded:

  • CI Success

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/ModularForms): the Dedekind Eta function [Merged by Bors] - feat(NumberTheory/ModularForms): the Dedekind Eta function Aug 25, 2025
@mathlib-bors mathlib-bors bot closed this Aug 25, 2025
FormulaRabbit81 pushed a commit to YaelDillies/mathlib4 that referenced this pull request Aug 30, 2025
…r-community#28400)

We define the Dedekind eta function in preparation for later relating it to Eisenstein series and the modular form Delta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants